Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linux/s390x architecture #8214

Merged

Conversation

bwalk-at-ibm
Copy link
Contributor

The s390x CPU architecture is the base for IBM zSeries (aka mainframe) systems. It is beneficial for users of this platform to have a supported way to install pre-compiled binaries for the OpenTelemetry collector in a Linux environment. This issue and associated pull requests will enable the building of all relevant binary artifacts for linux/s390x as part of the regular CI pipeline.

IBM has performed tests internally to ensure successful build (via cross-compilation) and runtime (on native platform) integrity of the OpenTelemetry collector (core and contrib) via the unit test suites and specific use-cases.

For more information and discussion please refer to the initial feature request issue (open-telemetry/opentelemetry-collector-releases#378).

Resolves: #8213

@bwalk-at-ibm bwalk-at-ibm requested review from a team and mx-psi August 10, 2023 07:29
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 10, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bwalk-at-ibm / name: Bjoern Walk (bfdcb97)

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08% 🎉

Comparison is base (92f5fe6) 90.18% compared to head (a6a099b) 90.27%.

❗ Current head a6a099b differs from pull request most recent head bfdcb97. Consider uploading reports for the commit bfdcb97 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8214      +/-   ##
==========================================
+ Coverage   90.18%   90.27%   +0.08%     
==========================================
  Files         302      301       -1     
  Lines       15859    15581     -278     
==========================================
- Hits        14303    14065     -238     
+ Misses       1261     1227      -34     
+ Partials      295      289       -6     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with merging this, with the understanding that this does not mean we support s390x and that until we tackle #8209 contributors are free to provide no-op implementations for s390x for new features if it would be a significant burden to support something on this architecture.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 25, 2023
@mx-psi
Copy link
Member

mx-psi commented Aug 28, 2023

@bwalk-at-ibm needs a rebase to pick up new tests on main

This commit enables platform support for the `linux/s390x` architecture
in the CI pipeline.

Signed-off-by: Bjoern Walk <[email protected]>
@bwalk-at-ibm bwalk-at-ibm force-pushed the s390x-platform-enablement branch from a6a099b to bfdcb97 Compare August 28, 2023 07:58
@bwalk-at-ibm
Copy link
Contributor Author

bwalk-at-ibm commented Aug 28, 2023

@mx-psi Done.

Not sure what the test failure is though. Any pointers if this is relevant to the PR and how to resolve it?

@mx-psi
Copy link
Member

mx-psi commented Aug 28, 2023

Looks good now :) cc @open-telemetry/collector-maintainers I think this is ready to merge

@github-actions github-actions bot removed the Stale label Aug 29, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 12, 2023
@bwalk-at-ibm
Copy link
Contributor Author

Is there anything required from my side that blocks the merge?

@mx-psi mx-psi removed the Stale label Sep 12, 2023
@mx-psi
Copy link
Member

mx-psi commented Sep 12, 2023

ping @open-telemetry/collector-maintainers

@codeboten codeboten merged commit 127daef into open-telemetry:main Sep 12, 2023
3 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linux/s390x architecture to CI build pipeline
3 participants