-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for linux/s390x architecture #8214
Add support for linux/s390x architecture #8214
Conversation
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8214 +/- ##
==========================================
+ Coverage 90.18% 90.27% +0.08%
==========================================
Files 302 301 -1
Lines 15859 15581 -278
==========================================
- Hits 14303 14065 -238
+ Misses 1261 1227 -34
+ Partials 295 289 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with merging this, with the understanding that this does not mean we support s390x and that until we tackle #8209 contributors are free to provide no-op implementations for s390x for new features if it would be a significant burden to support something on this architecture.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@bwalk-at-ibm needs a rebase to pick up new tests on main |
This commit enables platform support for the `linux/s390x` architecture in the CI pipeline. Signed-off-by: Bjoern Walk <[email protected]>
a6a099b
to
bfdcb97
Compare
@mx-psi Done. Not sure what the test failure is though. Any pointers if this is relevant to the PR and how to resolve it? |
Looks good now :) cc @open-telemetry/collector-maintainers I think this is ready to merge |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Is there anything required from my side that blocks the merge? |
ping @open-telemetry/collector-maintainers |
The
s390x
CPU architecture is the base for IBM zSeries (aka mainframe) systems. It is beneficial for users of this platform to have a supported way to install pre-compiled binaries for the OpenTelemetry collector in a Linux environment. This issue and associated pull requests will enable the building of all relevant binary artifacts forlinux/s390x
as part of the regular CI pipeline.IBM has performed tests internally to ensure successful build (via cross-compilation) and runtime (on native platform) integrity of the OpenTelemetry collector (core and contrib) via the unit test suites and specific use-cases.
For more information and discussion please refer to the initial feature request issue (open-telemetry/opentelemetry-collector-releases#378).
Resolves: #8213