Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changelog #8089

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix changelog #8089

merged 1 commit into from
Jul 13, 2023

Conversation

codeboten
Copy link
Contributor

missed adding an issue number

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested review from a team and bogdandrutu July 13, 2023 19:20
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (38ba4d5) 90.60% compared to head (f718bea) 90.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8089      +/-   ##
==========================================
- Coverage   90.60%   90.56%   -0.04%     
==========================================
  Files         301      301              
  Lines       15209    15209              
==========================================
- Hits        13780    13774       -6     
- Misses       1148     1153       +5     
- Partials      281      282       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 13, 2023
@codeboten codeboten merged commit 879fe77 into open-telemetry:main Jul 13, 2023
@codeboten codeboten deleted the codeboten/add-issue branch July 13, 2023 21:03
@github-actions github-actions bot added this to the next release milestone Jul 13, 2023
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jul 14, 2023
…entries get committed (#24273)

See open-telemetry/opentelemetry-collector#8089
for origin.

When creating a chore PR, we don't check chloggen entries at all. If a
chore introduces a changelog entry, we should validate it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants