-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service/proctelemetry] Offer to override the HOST_PROC environment variable with a programmatic value #7998
[service/proctelemetry] Offer to override the HOST_PROC environment variable with a programmatic value #7998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!! the tests are failing but not related to the change
310eb9a
to
a2ce366
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7998 +/- ##
==========================================
- Coverage 90.82% 90.49% -0.34%
==========================================
Files 300 301 +1
Lines 15108 15727 +619
==========================================
+ Hits 13722 14232 +510
- Misses 1112 1207 +95
- Partials 274 288 +14
☔ View full report in Codecov by Sentry. |
515d4f9
to
a06efc6
Compare
… introduce an option to allow user to overwrite the unset logic and use the value set in the environment variable Signed-off-by: Dani Louca <[email protected]>
a06efc6
to
a4e9ff5
Compare
a4e9ff5
to
dbf19ea
Compare
Co-authored-by: Alex Boten <[email protected]>
778d9cd
to
0147fd5
Compare
0147fd5
to
2ba4d54
Compare
Reprising #7434
Description:
While debugging the below error in k8s env
I have noticed that the metric server is calling GOPSUTIL while the HOST_PROC variable is set , this causes gopsutil
PidExistsWithContext
to retrieve the process from the host instead from the containerThis PR unsets and resets the host_proc variable and introduces an option to allow the use of host_proc if for whatever reason they need to
Link to tracking Issue:
Fixes #7435
Testing:
unit tests