[chore] remove unnecessary additional tools #7852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7852 +/- ##
==========================================
+ Coverage 91.03% 91.12% +0.09%
==========================================
Files 299 299
Lines 14935 14935
==========================================
+ Hits 13596 13610 +14
+ Misses 1061 1050 -11
+ Partials 278 275 -3 ☔ View full report in Codecov by Sentry. |
|
Will spend some time trying to figure out why the coverage dropped from this change. |
This is replicating the setup in the contrib repo that doesn't use go-acc & gcovmerge for coverage. Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/coverate-rm-addtl-tools
branch
from
7e2937f to
b843ba1
Compare
Signed-off-by: Alex Boten <[email protected]>
Found the missing coverage, needed to pass in |
djaglowski
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replicating the setup in the contrib repo that doesn't use go-acc & gcovmerge for coverage. It uses tools built into go 1.20 instead