[exporterhelper] log storage errors with higher severity #7477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7477 +/- ##
==========================================
- Coverage 91.16% 91.13% -0.03%
==========================================
Files 294 294
Lines 14265 14267 +2
==========================================
- Hits 13004 13002 -2
- Misses 996 999 +3
- Partials 265 266 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The persistent queue tries to persist its state to storage whenever it changes. If it fails, it simply continues, which may not be the right decision in some cases. Either way, these kinds of errors signify a major problem with the underlying storage medium - typically it's either full, or the underlying hardware is faulty.
I'd like to rework how this error handling works in general, but in this change I just want to make the errors more visible to help with post-factum debugging.
See #7396 for more context as well.
Link to tracking Issue: Related to #7198