Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable useOtelForInternalMetrics by default #7453

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Mar 29, 2023

Following up on enabling otel metrics by default as per the comment #5687 (comment)

Fixes #7454

Following up on enabling otel metrics by default as per the comment open-telemetry#5687 (comment)

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten marked this pull request as ready for review March 29, 2023 15:33
@codeboten codeboten requested review from a team and Aneurysm9 March 29, 2023 15:33
@bogdandrutu
Copy link
Member

Here is an issue that we need to investigate #6403

@codeboten
Copy link
Contributor Author

Here's the PR to enable normalization by default: open-telemetry/opentelemetry-collector-contrib#20519, moving this PR back into draft until some of the work listed in #7454 is addressed

@codeboten codeboten marked this pull request as draft March 29, 2023 22:54
@dmitryax
Copy link
Member

Did we migrate all the metrics? AFAIR, there are some components that still don't expose OTel metrics like exporter queue

@codeboten
Copy link
Contributor Author

Did we migrate all the metrics? AFAIR, there are some components that still don't expose OTel metrics like exporter queue

@dmitryax There was a decision made at some point to use prometheus as a bridge for opencensus metrics. Today, when useOtelForInternalMetrics is enabled, both otel and opencensus are reporting metrics.

This is somewhat confusing in the code at this point, but it was a decision that prevented us from having to move all metrics to otel.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 18, 2023
@codeboten codeboten removed the Stale label Apr 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 5, 2023
@codeboten codeboten removed the Stale label May 8, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 23, 2023
@codeboten codeboten removed the Stale label May 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 7, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work needed to enable useOtelForInternalMetrics by default
3 participants