-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable useOtelForInternalMetrics
by default
#7453
Enable useOtelForInternalMetrics
by default
#7453
Conversation
Following up on enabling otel metrics by default as per the comment open-telemetry#5687 (comment) Signed-off-by: Alex Boten <[email protected]>
Here is an issue that we need to investigate #6403 |
Here's the PR to enable normalization by default: open-telemetry/opentelemetry-collector-contrib#20519, moving this PR back into draft until some of the work listed in #7454 is addressed |
Did we migrate all the metrics? AFAIR, there are some components that still don't expose OTel metrics like exporter queue |
@dmitryax There was a decision made at some point to use prometheus as a bridge for opencensus metrics. Today, when useOtelForInternalMetrics is enabled, both otel and opencensus are reporting metrics. This is somewhat confusing in the code at this point, but it was a decision that prevented us from having to move all metrics to otel. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Following up on enabling otel metrics by default as per the comment #5687 (comment)
Fixes #7454