Disambiguate component ID in 'connectortest' package #7110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
changed the title
Codecov ReportBase: 90.59% // Head: 90.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7110 +/- ##
=======================================
Coverage 90.59% 90.59%
=======================================
Files 293 293
Lines 14250 14254 +4
=======================================
+ Hits 12910 12914 +4
Misses 1072 1072
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
All checks have passed with the feature gate enabled: https://github.com/open-telemetry/opentelemetry-collector/pull/7110/checks?check_run_id=11095874904 |
bogdandrutu
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different ID than
receivertestandexportertestto avoid ambiguous configuration scenarios. Ambiguous IDs are detected in theotelcolpackage, but lower level packages such asserviceassume that IDs are disambiguated.To demonstrate this working with the connectors feature gate enabled, I've temporarily updated the gate level to beta. Once tests pass, I will revert the gate level to alpha.