Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [pdata] Simplify EnsureCapacity tests #7099

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Feb 2, 2023

This brings slicePtr and sliceValue tests the same view which helps to consolidate them

@dmitryax dmitryax requested review from a team and mx-psi February 2, 2023 22:59
@dmitryax dmitryax changed the title [chore] [pdata] Simply EnsureCapacity tests [chore] [pdata] Simplify EnsureCapacity tests Feb 2, 2023
@dmitryax dmitryax force-pushed the simplify-ensure-capacity-tests branch from 812e502 to 7fce87c Compare February 2, 2023 23:38
This brings slicePtr and sliceValue tests the the same view which helps to consolidate them
@dmitryax dmitryax force-pushed the simplify-ensure-capacity-tests branch from 7fce87c to b34aa82 Compare February 2, 2023 23:43
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 89.46% // Head: 89.46% // No change to project coverage 👍

Coverage data is based on head (b34aa82) compared to base (297e391).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7099   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         293      293           
  Lines       14071    14071           
=======================================
  Hits        12588    12588           
  Misses       1215     1215           
  Partials      268      268           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmitryax dmitryax merged commit 33e5265 into open-telemetry:main Feb 2, 2023
@dmitryax dmitryax deleted the simplify-ensure-capacity-tests branch February 3, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants