Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pipelineSettings fields with Builder #7093

Merged

Conversation

djaglowski
Copy link
Member

Resolves #7089

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 89.37% // Head: 89.37% // No change to project coverage 👍

Coverage data is based on head (3ef2866) compared to base (c0a08e3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7093   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files         286      286           
  Lines       14020    14020           
=======================================
  Hits        12531    12531           
  Misses       1219     1219           
  Partials      270      270           
Impacted Files Coverage Δ
service/pipelines.go 93.93% <100.00%> (ø)
service/service.go 66.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski marked this pull request as ready for review February 2, 2023 02:32
@djaglowski djaglowski requested review from a team and Aneurysm9 February 2, 2023 02:32
@bogdandrutu
Copy link
Member

Skipping contrib tests since they are broken for other reasons.

@bogdandrutu bogdandrutu merged commit 83599a7 into open-telemetry:main Feb 2, 2023
@djaglowski djaglowski deleted the pipeline-settings-builders branch February 2, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename pipelineSettings.<Type> to <Type>Builder
2 participants