Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [pdata] Split Value/Map/Slice into separate files #7083

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jan 30, 2023

For better readability

@dmitryax dmitryax requested review from a team and djaglowski January 30, 2023 23:14
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 89.33% // Head: 89.33% // No change to project coverage 👍

Coverage data is based on head (daf4713) compared to base (a2f0153).
Patch coverage: 96.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7083   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files         239      241    +2     
  Lines       13989    13989           
=======================================
  Hits        12497    12497           
  Misses       1221     1221           
  Partials      271      271           
Impacted Files Coverage Δ
pdata/pcommon/value.go 94.23% <ø> (ø)
pdata/pcommon/map.go 94.15% <94.15%> (ø)
pdata/pcommon/slice.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit fe3b4f8 into open-telemetry:main Jan 31, 2023
@dmitryax dmitryax deleted the pdata-split-common branch January 31, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants