[pdata] Do not wrap orig fields when it's not required #7081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 89.86% // Head: 89.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7081 +/- ##
==========================================
- Coverage 89.86% 89.33% -0.54%
==========================================
Files 245 239 -6
Lines 14721 13989 -732
==========================================
- Hits 13229 12497 -732
Misses 1221 1221
Partials 271 271
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
approved these changes
Jan 30, 2023
This change simplifies the generated pdata code to not wrap orig fields in the internal package for structs that are not being used by other packages. The code generator is adjusted to generate wrapped or unwrapped code for only for structs that need it based on the package name. The only exception is `Slice` struct that was pulled from the generator because: - We don't have and don't expect to have any new slices that are used by other packages. - The `Slice` struct have two additional methods `AsRaw` and `FromRaw` that are not generated and defined in a separate file which is a bit confusing.
dmitryax
force-pushed
the
simplify-pdata
branch
from
1d43ae7 to
9efb7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the generated pdata code to not wrap
origfields in the internal package for structs that are not being used by other packages.The code generator is adjusted to generate wrapped or unwrapped code only for structs that need it based on the package name. The only exception is
Slicestruct that was pulled from the generator because:Slicestruct has two additional methodsAsRawandFromRawwhich are not generated and defined in a separate file which is a bit confusing.This simplification is also needed for #6794 PoCs