-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for concatenating multiple embedded uris, or uris with other string parts #7055
Conversation
a9ff48f
to
e2ea2ee
Compare
Codecov ReportBase: 89.33% // Head: 89.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7055 +/- ##
==========================================
+ Coverage 89.33% 89.35% +0.01%
==========================================
Files 239 239
Lines 13989 14014 +25
==========================================
+ Hits 12497 12522 +25
Misses 1221 1221
Partials 271 271
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e2ea2ee
to
a158b17
Compare
a158b17
to
edb004a
Compare
65a7910
to
932980e
Compare
932980e
to
432fdf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with merging as is, but we will need to figure out how to enforce env var strings going forward. Maybe as a separate issue
432fdf2
to
2781df4
Compare
…her string parts Signed-off-by: Bogdan Drutu <[email protected]>
2781df4
to
c93d192
Compare
Fixes #6932