Change API to be a bit more go friendly. #7040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to FlagSet.Lookup where return pointers, clarifies that nil when error instead of invalid instance. This is not breaking change since this API was added in this version. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
added
the
Skip Changelog
dmitryax
approved these changes
Jan 27, 2023
Codecov ReportBase: 89.94% // Head: 89.94% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #7040 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 245 245
Lines 14712 14712
=======================================
Hits 13232 13232
Misses 1210 1210
Partials 270 270
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
added this to the `go.opentelemetry.io/collector/featuregate` 1.0 milestone
MovieStoreGuy
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to FlagSet.Lookup where return pointers, clarifies that nil when error instead of invalid instance. This is not breaking change since this API was added in this version.
Signed-off-by: Bogdan Drutu [email protected]