Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated pcommon.Map.Sort #7028

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

bogdandrutu
Copy link
Member

Fixes #6688

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and djaglowski January 25, 2023 23:47
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 89.37% // Head: 89.37% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (551fcf7) compared to base (272ebe6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7028      +/-   ##
==========================================
- Coverage   89.37%   89.37%   -0.01%     
==========================================
  Files         286      286              
  Lines       14017    14012       -5     
==========================================
- Hits        12528    12523       -5     
  Misses       1219     1219              
  Partials      270      270              
Impacted Files Coverage Δ
pdata/pcommon/map.go 93.95% <ø> (-0.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmitryax
Copy link
Member

dmitryax commented Feb 1, 2023

@bogdandrutu, contrib test is passing now. Please rebase

@bogdandrutu bogdandrutu merged commit 84c3d00 into open-telemetry:main Feb 2, 2023
@bogdandrutu bogdandrutu deleted the rmsort branch February 2, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdata Map.Sort() leaks underlying storage behavior and prevents future optimizations
2 participants