-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument proctelemetry.ProcessMetrics #6886
Instrument proctelemetry.ProcessMetrics #6886
Conversation
Codecov ReportBase: 89.37% // Head: 89.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6886 +/- ##
==========================================
- Coverage 89.37% 89.28% -0.10%
==========================================
Files 286 283 -3
Lines 14017 14093 +76
==========================================
+ Hits 12528 12583 +55
- Misses 1219 1233 +14
- Partials 270 277 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@jpkrohling @bogdandrutu @paivagustavo This is my latest instrumentation PR. It should be ready for review if y'all have any feedback! Thank you! |
Looks good to me. FWIW eventually I would like to see this stuff replaced with an otel-go metrics instrumentation library, for example here https://github.com/lightstep/otel-launcher-go/tree/main/lightstep/instrumentation/runtime. |
e105849
to
fc77a3b
Compare
72aa2ba
to
81186dc
Compare
81186dc
to
d6d6d4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs updates because of API update in otel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase, will need API fixes.
d6e6442
to
ec5824c
Compare
@bogdandrutu Thanks for pointing this out! I just updated based on the otel api changes. Can you please take another look? |
ec5824c
to
6a3b6e3
Compare
f9d294f
to
cff7f30
Compare
* Instrument proctelemetry.ProcessMetrics
cff7f30
to
95b539f
Compare
@bogdandrutu @codeboten I rebased my change but noticed the contrib tests are now failing. Does the contrib repo need to be updated or is there a recent commit in the last 15 hours that is causing this failure? I don't see any references to |
Description:
This PR instruments proctelemetry.ProcessMetrics with otel go. This is a followup PR that is based on similar changes made for obsreport.Receiver: #6222
Link to tracking Issue: Part of #816
Testing:
Built otelcorecol binary and checked metrics endpoint. Tested with and without featuregate.