Fix: Force usage of case-sensitive keys in configurations #6876
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.64% // Head: 90.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6876 +/- ##
==========================================
+ Coverage 90.64% 90.66% +0.02%
==========================================
Files 241 241
Lines 14523 14526 +3
==========================================
+ Hits 13164 13170 +6
+ Misses 1091 1089 -2
+ Partials 268 267 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rapphil
force-pushed
the
rapphil-fix-loglevel
branch
2 times, most recently
from
bbf7182 to
923fd8e
Compare
gbbr
reviewed
Jan 3, 2023
Aneurysm9
approved these changes
Jan 3, 2023
jpkrohling
reviewed
Jan 10, 2023
Aneurysm9
approved these changes
Jan 19, 2023
Aneurysm9
added
the
ready-to-merge
Signed-off-by: Raphael Silva <[email protected]>
Co-authored-by: Gabriel Aszalos <[email protected]>
Co-authored-by: Gabriel Aszalos <[email protected]>
Signed-off-by: Raphael Silva <[email protected]>
rapphil
force-pushed
the
rapphil-fix-loglevel
branch
from
e201ab8 to
2d4e30d
Compare
bogdandrutu
pushed a commit
that referenced
this pull request
Jan 21, 2023
)" This reverts commit 8fa8408.
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jan 23, 2023
…etry#6876) * Fix: Force usage of case-sensitive keys in configurations Signed-off-by: Raphael Silva <[email protected]> * Update confmap/confmap.go Co-authored-by: Gabriel Aszalos <[email protected]> * Update .chloggen/case-sensitive-configuration.yaml Co-authored-by: Gabriel Aszalos <[email protected]> * convert caseSensitiveMatchName to a plain function Signed-off-by: Raphael Silva <[email protected]> Signed-off-by: Raphael Silva <[email protected]> Co-authored-by: Gabriel Aszalos <[email protected]>
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jan 23, 2023
gbbr
added a commit
to gbbr/opentelemetry-collector
that referenced
this pull request
Jan 25, 2023
…ions (open-telemetry#6876)" (open-telemetry#6988)" This reverts commit 80cabdd. Closes open-telemetry#7002
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raphael Silva [email protected]
Description: Fix bug that allowed users to specify invalid configurations that would pass validation but would not work properly or fail silently. E.g.:
loglevel. If you specifylogLevel, the validation would pass but the collector logging exporter would not produce logs.Testing: Added unit test before changing the code.