Deprecate component.Factories in favor of service.Factories #6723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
commented
Dec 9, 2022
Codecov ReportBase: 89.44% // Head: 89.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6723 +/- ##
==========================================
+ Coverage 89.44% 89.46% +0.02%
==========================================
Files 248 248
Lines 14285 14285
==========================================
+ Hits 12777 12780 +3
+ Misses 1258 1256 -2
+ Partials 250 249 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
djaglowski
force-pushed
the
refactories
branch
4 times, most recently
from
4282666 to
6eb6bdd
Compare
djaglowski
force-pushed
the
refactories
branch
2 times, most recently
from
737d3bf to
fe3f046
Compare
bogdandrutu
approved these changes
Dec 12, 2022
|
You need a rebase. |
djaglowski
force-pushed
the
refactories
branch
from
fe3f046 to
ed88d05
Compare
djaglowski
force-pushed
the
refactories
branch
from
ed88d05 to
4c8f169
Compare
|
Done |
|
Please I am trying to follow the reason behind the changes, is there an issue that this is linked to, please? |
|
It's related to #6578. The overall goal here is to simplify the components package so that it can be declared stable. |
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.