[chore] remove usage of component.Factories in service/extiension #6674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
Codecov ReportBase: 91.13% // Head: 91.13% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6674 +/- ##
=======================================
Coverage 91.13% 91.13%
=======================================
Files 244 244
Lines 14168 14168
=======================================
Hits 12912 12912
Misses 1006 1006
Partials 250 250 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mx-psi
approved these changes
Dec 5, 2022
codeboten
approved these changes
Dec 5, 2022
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
…en-telemetry#6674) Signed-off-by: Bogdan Drutu <[email protected]>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
…en-telemetry#6674) Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #6578
Factories will need to be moved away from component to not cause circular dependencies, these PRs help with determining where that struct is used.