Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move exporter Factory and types to exporter package #6672

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Move exporter Factory and types to exporter package #6672

merged 1 commit into from
Dec 7, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Dec 2, 2022 •
edited
Loading

Updates #6578

@bogdandrutu bogdandrutu requested review from a team and codeboten December 2, 2022 20:33
@codecov
Copy link

codecov bot commented Dec 2, 2022 •
edited
Loading

Codecov Report

Base: 90.89% // Head: 90.36% // Decreases project coverage by -0.53% ⚠️

Coverage data is based on head (13f7c7b) compared to base (8d11723).
Patch coverage: 87.93% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6672      +/-   ##
==========================================
- Coverage   90.89%   90.36%   -0.54%     
==========================================
  Files         244      244              
  Lines       14161    14161              
==========================================
- Hits        12872    12796      -76     
- Misses       1039     1115      +76     
  Partials      250      250
Impacted Files Coverage Δ
component/componenttest/nop_exporter.go 0.00% <0.00%> (-100.00%) ⬇️
component/componenttest/nop_factories.go 0.00% <ø> (ø)
component/exporter.go 0.00% <ø> (-100.00%) ⬇️
component/factories.go 50.00% <ø> (-25.00%) ⬇️
obsreport/obsreport_exporter.go 97.90% <ø> (ø)
exporter/exporterhelper/common.go 90.80% <100.00%> (ø)
exporter/exporterhelper/logs.go 80.64% <100.00%> (ø)
exporter/exporterhelper/metrics.go 80.64% <100.00%> (ø)
exporter/exporterhelper/traces.go 80.95% <100.00%> (ø)
exporter/loggingexporter/factory.go 88.88% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu force-pushed the deprecatecompexp branch 2 times, most recently from 2163edd to 9bf9c3d Compare December 2, 2022 21:06
dmitryax
dmitryax approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit 6a2dc30 into open-telemetry:main Dec 7, 2022
@bogdandrutu bogdandrutu deleted the deprecatecompexp branch December 7, 2022 18:20
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Dec 8, 2022
@bogdandrutu
Mark as deprecated componenttest exporter related funcs
d872c29 
This was a miss from open-telemetry#6672

Skipping changelog since covered in https://github.com/open-telemetry/opentelemetry-collector/blob/main/.chloggen/deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu mentioned this pull request Dec 8, 2022
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Dec 8, 2022
@bogdandrutu
Mark as deprecated componenttest exporter related funcs
a7b5152 
This was a miss from open-telemetry#6672

Skipping changelog since covered in https://github.com/open-telemetry/opentelemetry-collector/blob/main/.chloggen/deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit that referenced this pull request Dec 8, 2022
@bogdandrutu
Mark as deprecated componenttest exporter related funcs (#6707)
c56b7d3 
* Mark as deprecated componenttest exporter related funcs

This was a miss from #6672

Skipping changelog since covered in https://github.com/open-telemetry/opentelemetry-collector/blob/main/.chloggen/deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <[email protected]>

* Update deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <[email protected]>
jaronoff97 added a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@jaronoff97
Move exporter Factory and types to exporter package (open-telemetry#6672
9278bee 
)

Signed-off-by: Bogdan Drutu <[email protected]>

Signed-off-by: Bogdan Drutu <[email protected]>
jaronoff97 added a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@jaronoff97
Mark as deprecated componenttest exporter related funcs (open-telemet…
152f020 
…ry#6707)

* Mark as deprecated componenttest exporter related funcs

This was a miss from open-telemetry#6672

Skipping changelog since covered in https://github.com/open-telemetry/opentelemetry-collector/blob/main/.chloggen/deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <[email protected]>

* Update deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <[email protected]>
jaronoff97 added a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@jaronoff97
Move exporter Factory and types to exporter package (open-telemetry#6672
6779219 
)

Signed-off-by: Bogdan Drutu <[email protected]>

Signed-off-by: Bogdan Drutu <[email protected]>
jaronoff97 added a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@jaronoff97
Mark as deprecated componenttest exporter related funcs (open-telemet…
4970839 
…ry#6707)

* Mark as deprecated componenttest exporter related funcs

This was a miss from open-telemetry#6672

Skipping changelog since covered in https://github.com/open-telemetry/opentelemetry-collector/blob/main/.chloggen/deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <[email protected]>

* Update deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdandrutu @dmitryax