Fix support for concatenating envvars with colon #6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.91% // Head: 90.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6593 +/- ##
==========================================
+ Coverage 90.91% 90.94% +0.02%
==========================================
Files 241 241
Lines 14082 14084 +2
==========================================
+ Hits 12803 12809 +6
+ Misses 1027 1023 -4
Partials 252 252
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
fixconfmap
branch
from
6758c4c to
822a73a
Compare
dmitryax
approved these changes
Nov 21, 2022
dmitryax
approved these changes
Nov 21, 2022
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
* Fix support for concatenating envvars with colon Signed-off-by: Bogdan Drutu <[email protected]> * Update resolver.go Signed-off-by: Bogdan Drutu <[email protected]>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
* Fix support for concatenating envvars with colon Signed-off-by: Bogdan Drutu <[email protected]> * Update resolver.go Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6580