Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recursive validation check for configs #6545

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Add recursive validation check for configs #6545

merged 1 commit into from
Nov 22, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Nov 15, 2022 •
edited
Loading

Fixes #4584

@codecov
Copy link

codecov bot commented Nov 15, 2022 •
edited
Loading

Codecov Report

Base: 91.07% // Head: 91.12% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (2dfa032) compared to base (776c6b3).
Patch coverage: 97.95% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6545      +/-   ##
==========================================
+ Coverage   91.07%   91.12%   +0.04%     
==========================================
  Files         241      241              
  Lines       14064    14109      +45     
==========================================
+ Hits        12809    12857      +48     
+ Misses       1003     1002       -1     
+ Partials      252      250       -2
Impacted Files Coverage Δ
component/config.go 87.50% <97.95%> (+87.50%) ⬆️
internal/iruntime/total_memory_linux.go 36.66% <0.00%> (-3.34%) ⬇️
internal/cgroups/cgroups.go 91.78% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu mentioned this pull request Nov 18, 2022
Closed
@mattsains mattsains mentioned this pull request Nov 18, 2022
Closed
@dmitryax
Copy link
Member

@bogdandrutu can you please rebase it?

@bogdandrutu bogdandrutu reopened this Nov 22, 2022
@bogdandrutu bogdandrutu changed the title Deepvalidate Add recursive validation check for configs Nov 22, 2022
dmitryax
dmitryax reviewed Nov 22, 2022
View reviewed changes
component/config.go Outdated Show resolved Hide resolved
dmitryax
dmitryax reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. It would be great to see how it works on some unit tests

component/config.go Outdated Show resolved Hide resolved
@bogdandrutu

This comment was marked as outdated.

Sign in to view
@bogdandrutu
Copy link
Member Author

It would be great to see how it works on some unit tests

Lots were added.

@bogdandrutu bogdandrutu marked this pull request as ready for review November 22, 2022 16:29
@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 November 22, 2022 16:30
dmitryax
dmitryax approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit 5376db4 into open-telemetry:main Nov 22, 2022
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@bogdandrutu @jaronoff97
Add recursive validation check for configs (open-telemetry#6545)
6c6d238 
Signed-off-by: Bogdan Drutu <[email protected]>

Signed-off-by: Bogdan Drutu <[email protected]>
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@bogdandrutu @jaronoff97
Add recursive validation check for configs (open-telemetry#6545)
1832296 
Signed-off-by: Bogdan Drutu <[email protected]>

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu deleted the deepvalidate branch October 14, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exporterhelper should reject a queue size of 0
2 participants
@bogdandrutu @dmitryax