Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports new Prometheus receiver from OpenCensus. #65

Merged
merged 3 commits into from
Jun 28, 2019
Merged

Imports new Prometheus receiver from OpenCensus. #65

merged 3 commits into from
Jun 28, 2019

Conversation

dinooliva
Copy link
Contributor

We'd like to use the new Prometheus receiver with the OpenTelemetry agent.

@songy23
Copy link
Member

songy23 commented Jun 28, 2019

Please fix CLA and run GO111MODULE=on go mod tidy.

@dinooliva
Copy link
Contributor Author

Note: This code is copied from the original pull request to opencensus-service: census-instrumentation/opencensus-service#572

@dinooliva
Copy link
Contributor Author

CLA signed.

@codecov-io
Copy link

Codecov Report

Merging #65 into master will increase coverage by 1.78%.
The diff coverage is 94.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   69.58%   71.37%   +1.78%     
==========================================
  Files          86       91       +5     
  Lines        5606     6022     +416     
==========================================
+ Hits         3901     4298     +397     
- Misses       1485     1500      +15     
- Partials      220      224       +4
Impacted Files Coverage Δ
...iver/prometheusreceiver/internal/metricsbuilder.go 100% <100%> (ø)
receiver/prometheusreceiver/internal/ocastore.go 71.42% <71.42%> (ø)
receiver/prometheusreceiver/metrics_receiver.go 70.17% <74.19%> (-4.34%) ⬇️
receiver/prometheusreceiver/internal/metadata.go 75% <75%> (ø)
receiver/prometheusreceiver/internal/logger.go 77.77% <77.77%> (ø)
...eceiver/prometheusreceiver/internal/transaction.go 96.36% <96.36%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a643a7...6df9ad0. Read the comment docs.

@songy23 songy23 merged commit f28c6b8 into open-telemetry:master Jun 28, 2019
@tigrannajaryan
Copy link
Member

@dinooliva this changes looks incomplete to me. This requires fixing Preceiver creation in prometheusreceiver/factory.go to pass the logger. That in turn will require CreateMetricsReceiver() to accept the logger as a parameter.

While there I'd also make Preceiver creation via a proper New() function instead of constructing a struct to make sure any future changes to Preceiver construction cause compiler error.

@tigrannajaryan tigrannajaryan mentioned this pull request Jun 28, 2019
Closed
@dinooliva dinooliva deleted the new-prometheusreceiver branch June 28, 2019 17:41
@songy23 songy23 mentioned this pull request Jun 28, 2019
Closed
@flands flands added this to the 0.1.0 milestone Jul 2, 2019
bogdandrutu added a commit that referenced this pull request Oct 28, 2021
@jpkrohling @bogdandrutu
@joe-elliott @jiwen624 @Ashmita152 @fangyi-zhou @crearys @pmalek-sumo @secat @sodabrew @pmalek @KKelvinLo @himanshu007-creator @u5surf @zchee @Aneurysm9 @loomis-relativity
Move opentelemetry-collector-builder to core (#4286)
4063a46 
* Initial commit

* Add CODEOWNERS file (#2)

* Add CODEOWNERS file

* Update CODEOWNERS

* Moved from github.com/observatorium/opentelemetry-collector-builder (#3)

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* fixed panics (#6)

Signed-off-by: Joe Elliott <[email protected]>

* Replace master with main in CI and mergify files (#8)

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Bump to OpenTelemetry Collector 0.20.0 (#10)

Closes #9

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Explicitly enable Go modules in quickstart instructions (#13)

* Update to collector v0.21.0 (#17)

Fixes #16

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update to collector v0.22.0 (#19)

* Download go modules before building (#20)

Fixes #14

* Add version command (#25)

Signed-off-by: Ashmita Bohara <[email protected]>

* Pass errors from cobra Execute back to main for correct exit code (#28)

* pass errors from cobra execute back to main

* print the error

* Update to collector v0.23.0 (#27)

* Generate a warning if the builder and collector base version mismatch (#30)

* Generate a warning if the builder and collector base version mismatch

* Show current default version in the warning message

* Update to OpenTelemetry Collector 0.24.0

* Don't use %w formatting with log.Fatal (#35)

* Update to OpenTelemetry Collector 0.25.0 (#36)

Signed-off-by: Serge Catudal <[email protected]>

* Update to 0.26.0 and update BuildInfo (#39)

* Sync build and CI Go versions at latest 1.16 (#34)

* Sync build and CI Go versions at latest 1.16

* Run go mod tidy

* Set go binary to use in the compilation phase in tests

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* Add option to generate go code only (no compile) (#40)

* Issue#24 Add option to generate go code only (no compile)

* Update cmd/root.go logging

Suggested by @jpkkrohling

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* remove verbose help .. created by corba

* suggestion by jpkrohling to keep generateandcompile

* lint error: remove unused var

* reword cmd option and add back help message for default

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* Don't reuse exec.Cmd (#42)

* Update to OpenTelemetry Collector 0.27.0 (#43)

* Add CI Badge (#47)

* Update to Collector v0.28.0 (#49)

* Update to Collector v0.28.0

Closes #48

Addresses the breaking API change in
#3163,
besides the usual version number changes.

Signed-off-by: Fangyi Zhou <[email protected]>

* Use `go mod tidy` instead of `go mod download`

It appears that this magically resolves the go.mod file issue.
https://stackoverflow.com/questions/67203641/missing-go-sum-entry-for-module-providing-package-package-name

Signed-off-by: Fangyi Zhou <[email protected]>

* Account for go mod download in go1.17 not updating go.sum (#50)

* Update to collector v0.29.0 (#54)

* Update replaces.builder.yaml

* Update nocore.builder.yaml

* Update config.go

* Update README.md

* Update main.go

* Update to collector v0.30.0 (#57)

* cmd: fix module flag default value to github.com/open-telemetry (#58)

Signed-off-by: Koichi Shiraishi <[email protected]>

* Update to collector v0.31.0 (#60)

* Update to v0.33.0 (#62)

Signed-off-by: Anthony J Mirabella <[email protected]>

* Add excludes support to generated go.mod (#63)

Signed-off-by: Anthony J Mirabella <[email protected]>

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* Small cleanup for the builder files (#64)

Signed-off-by: Bogdan Drutu <[email protected]>

* Support building with Go 1.17 (#66)

* Support building with Go 1.17
Fixes #65

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update workflows to use Go 1.17

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Add gosec exceptions for exec.Command

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update to OpenTelemetry core 0.34.0 (#68)

Fixes #67

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Upgrade to OpenTelemetry Collector 0.35.0 (#70)

Signed-off-by: Fangyi Zhou <[email protected]>

* Upgrade to OpenTelemetry Collector 0.36.0 (#76)

* Generate custom service code for Windows (#75)

* update main to include windows service code

* use main version from tag 0.35.0

* update main function

* align with upstream v0.36.0 tag

* dummy change to trigger build

* Revert "dummy change to trigger build"

This reverts commit 629d499461da2d2c240bf1e495b5fe0558e3547f.

* Remove Core from Module type (#77)

Fixes #15

Signed-off-by: yugo-horie <[email protected]>

* release 0.37.0 (#78)

* release 0.37.0

* update use of NewCommand

* Move builder to subdirectory

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

Co-authored-by: Bogdan Drutu <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
Co-authored-by: Joe Elliott <[email protected]>
Co-authored-by: Eric Yang <[email protected]>
Co-authored-by: Brian Gibbins <[email protected]>
Co-authored-by: Ashmita <[email protected]>
Co-authored-by: Fangyi Zhou <[email protected]>
Co-authored-by: Shaun Creary <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Co-authored-by: Serge Catudal <[email protected]>
Co-authored-by: Aaron Stone <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Co-authored-by: Aaron Stone <[email protected]>
Co-authored-by: Kelvin Lo <[email protected]>
Co-authored-by: Himanshu <[email protected]>
Co-authored-by: Y.Horie <[email protected]>
Co-authored-by: Koichi Shiraishi <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Co-authored-by: Cal Loomis <[email protected]>
Co-authored-by: alrex <[email protected]>
bogdandrutu pushed a commit that referenced this pull request Oct 28, 2021
@jpkrohling
Support building with Go 1.17 (#66)
5bb4137 
* Support building with Go 1.17
Fixes #65

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update workflows to use Go 1.17

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Add gosec exceptions for exec.Command

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
@rghetia
Trace sdk (open-telemetry#65)
0f32efc 
* trace sdk initial commit.

* fix imports and comments.

* remove tracestate

* split trace.go

* add attribute over limit test.

* add comments and restructure span.go and tracer.go

* refactor MessageEvent

* defer unlock

* some more cleanup in span.go

* rename *MessageEvent* to *Event*

* cleanup comments in trace_test.go

* fix typos.

* return full string ID for traceID and spanID.
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
@atoulme
Add example showing the OpenTelemetry Collector used to receive Docke…
f3960d1 
…r logs (open-telemetry#65)

* Add example showing the OpenTelemetry Collector used to receive Docker logs

* remove the sleep statement since we rely on the ticker
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Plug the SpanProcessor into the Tracer implementation (open-telemetry#65
132aca1 
)
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
@Saber-W
Implement the validation that checks if every template file is up-to-…
6245f9e 
…date (open-telemetry#65)

This commit resolves the issue that the Helm chart maintainers need to manually compare the template files and the upstream manifest in order to determine which template files are outdated.

Example output of the release code:
```
2021/08/09 12:26:09 The OpenTelemetry Collector CRD update finished. It's up-to-date now.
2021/08/09 12:26:09 ATTENTION: opentelemetry-operator-leader-election-rolebinding configuration doesn't exist. Please create it in the file: rolebinding.yaml
2021/08/09 12:26:09 The values.yaml and Chart.yaml update finished. They are up-to-date now.
2021/08/09 12:26:09 ATTENTION: opentelemetry-operator-controller-manager configuration doesn't exist. Please create it in the file: deployment.yaml
2021/08/09 12:26:09 ATTENTION: validatingwebhookconfiguration.yaml file needs to be updated
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@flands flands Awaiting requested review from flands

@pjanotti pjanotti Awaiting requested review from pjanotti

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees

@dinooliva dinooliva

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dinooliva @songy23 @codecov-io @tigrannajaryan @flands