feat: add Dockerfile for ocb #6451
Conversation
Signed-off-by: Sakshi Patle <[email protected]>
|
@bogdandrutu @jpkrohling Once this is approved, I will add CI pipelines to build & push the docker images for the same to container registry for the project. |
Codecov ReportBase: 92.04% // Head: 92.04% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6451 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 237 237
Lines 13534 13534
=======================================
Hits 12458 12458
Misses 852 852
Partials 224 224 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Sakshi Patle <[email protected]>
| -installsuffix 'static' \ | ||
| -o /app ./main.go | ||
|
|
||
| CMD ["/app"] |
There was a problem hiding this comment.
| CMD ["/app"] | |
| CMD ["/app"] | |
|
Would the dockerfile and CI be best housed in https://github.com/open-telemetry/opentelemetry-collector-releases? |
There was a problem hiding this comment.
@TylerHelmuth I agree i think this should exist in the releases repo, since all the official docker containers are produced there
|
If thats the case, I can make the changes over there repo for the same.
…On Tue, 1 Nov 2022 at 21:05, Alex Boten ***@***.***> wrote:
***@***.**** commented on this pull request.
@TylerHelmuth <https://github.com/TylerHelmuth> I agree i think this
should exist in the releases repo, since all the official docker containers
are produced there
—
Reply to this email directly, view it on GitHub
<#6451 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANF3CEDRNS6DMAOFEWWTUHDWGE2FFANCNFSM6AAAAAARTWEEOY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
.com>
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I see the -releases repo as the one generating the official distributions. I'm not sure I see the other tools fitting that purpose, like telemetrygen or ocb. |
I suggested moving to the -releases repo as the collector builder should be released as an official tool no? i see telemetrygen as a development tool rather than something we officially support. That being said I'm not opposed to having tools released from other repos if it makes sense. Personally i find the release of the ocb binary from this repository more confusing than if we said "everything we release is the releases repo". |
|
I'm actually liking this idea now. I thought of the releases repo as "official distributions", but "official tools" as you pointed out is an interesting aspect as well. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Is this still a thing? ^^ |
|
Hey @sakshi1215 or anyone else; did this get dropped in favor of adding docker files to the releases repo? I think there would still be value in having a dockerfile in opentelemetry-collector/cmd/builder and am going to pick this up |
Signed-off-by: Sakshi Patle [email protected]
Description:
Adds dockerfile to build ocb docker image, tested in MacOS.
Link to tracking Issue:
fixes #5712