Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Export[Logs|Metrics|Traces]PartialSuccess, plugin into the Response #6361

Merged

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Oct 20, 2022

Depends on #6364

Fixes #5816
Fixes #5815

@bogdandrutu bogdandrutu requested review from a team and dmitryax October 20, 2022 02:12
@bogdandrutu bogdandrutu force-pushed the generatepartialresponse branch 3 times, most recently from 748f7a5 to 8030f9d Compare October 20, 2022 16:27
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@73ee7ea). Click here to learn what that means.
Patch coverage: 94.44% of modified lines in pull request are covered.

❗ Current head d27a09b differs from pull request most recent head 379d080. Consider uploading reports for the commit 379d080 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6361   +/-   ##
=======================================
  Coverage        ?   91.92%           
=======================================
  Files           ?      231           
  Lines           ?    13418           
  Branches        ?        0           
=======================================
  Hits            ?    12334           
  Misses          ?      860           
  Partials        ?      224           
Impacted Files Coverage Δ
pdata/plog/plogotlp/response.go 12.50% <0.00%> (ø)
pdata/pmetric/pmetricotlp/response.go 12.50% <0.00%> (ø)
pdata/ptrace/ptraceotlp/response.go 12.50% <0.00%> (ø)
pdata/internal/generated_wrapper_logs_otlp.go 100.00% <100.00%> (ø)
pdata/internal/generated_wrapper_metrics_otlp.go 100.00% <100.00%> (ø)
pdata/internal/generated_wrapper_traces_otlp.go 100.00% <100.00%> (ø)
pdata/plog/internal/plogjson/json.go 98.40% <100.00%> (ø)
pdata/plog/plogotlp/generated_logs_otlp.go 100.00% <100.00%> (ø)
pdata/pmetric/internal/pmetricjson/json.go 100.00% <100.00%> (ø)
...data/pmetric/pmetricotlp/generated_metrics_otlp.go 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmitryax
Copy link
Member

Does it need a changelog entry?

@bogdandrutu bogdandrutu force-pushed the generatepartialresponse branch 2 times, most recently from aeb4102 to d27a09b Compare October 20, 2022 16:52
@bogdandrutu
Copy link
Member Author

@dmitryax I am splitting more changes from this, will add when this gets to a reasonable size.

@bogdandrutu bogdandrutu force-pushed the generatepartialresponse branch from e1f0eaa to 379d080 Compare October 20, 2022 17:12
@bogdandrutu
Copy link
Member Author

@dmitryax PTAL

@bogdandrutu bogdandrutu merged commit 2758d1a into open-telemetry:main Oct 20, 2022
@bogdandrutu bogdandrutu deleted the generatepartialresponse branch October 20, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce partial success fields in ExportServiceResponse. Upgrade to OTLP proto version 0.19.0
2 participants