Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] document how set flag works, and current limitations #6321

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Oct 15, 2022

Updates #6294

@bogdandrutu bogdandrutu requested review from a team and tigrannajaryan October 15, 2022 13:28
@bogdandrutu
Copy link
Member Author

/cc @codeboten @dmitryax look at the limitations, let me know if you are ok with them, and also think if we have more.

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 92.06% // Head: 92.06% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (29a0b69) compared to base (ee02bc7).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 29a0b69 differs from pull request most recent head 057ebc5. Consider uploading reports for the commit 057ebc5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6321      +/-   ##
==========================================
- Coverage   92.06%   92.06%   -0.01%     
==========================================
  Files         219      219              
  Lines       13242    13241       -1     
==========================================
- Hits        12191    12190       -1     
  Misses        828      828              
  Partials      223      223              
Impacted Files Coverage Δ
service/flags.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu force-pushed the documentset branch 2 times, most recently from 7dac86d to 29a0b69 Compare October 15, 2022 13:45
service/README.md Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 4d44580 into open-telemetry:main Oct 17, 2022
@bogdandrutu bogdandrutu deleted the documentset branch October 17, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants