Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate overwritepropertiesconverter, only used by non builder distributions #6295

Merged

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Oct 13, 2022

Updates #6294

@bogdandrutu bogdandrutu requested review from a team and mx-psi October 13, 2022 00:46
@bogdandrutu bogdandrutu force-pushed the depoverwritepropertiesconverter branch from 401593f to fe496ce Compare October 13, 2022 00:47
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 92.03% // Head: 92.06% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (0a1e38d) compared to base (a9f41a2).
Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6295      +/-   ##
==========================================
+ Coverage   92.03%   92.06%   +0.03%     
==========================================
  Files         218      219       +1     
  Lines       13203    13242      +39     
==========================================
+ Hits        12151    12191      +40     
+ Misses        832      828       -4     
- Partials      220      223       +3     
Impacted Files Coverage Δ
...nverter/overwritepropertiesconverter/properties.go 100.00% <ø> (ø)
service/command.go 64.28% <0.00%> (+9.74%) ⬆️
service/flags.go 100.00% <100.00%> (+19.23%) ⬆️
service/service.go 69.44% <0.00%> (-1.99%) ⬇️
service/telemetry.go 87.57% <0.00%> (-1.46%) ⬇️
pdata/plog/logs.go 96.00% <0.00%> (ø)
confmap/resolver.go 98.13% <0.00%> (ø)
pdata/pmetric/metrics.go 100.00% <0.00%> (ø)
pdata/plog/plogotlp/logs.go 51.06% <0.00%> (ø)
pdata/pcommon/trace_state.go 100.00% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu force-pushed the depoverwritepropertiesconverter branch 4 times, most recently from b79a0b2 to f84062e Compare October 13, 2022 01:17
CHANGELOG.md Outdated Show resolved Hide resolved
service/flags.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu force-pushed the depoverwritepropertiesconverter branch 2 times, most recently from 01780f0 to f93363e Compare October 13, 2022 15:48
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like chloggen is broken? cc @codeboten

@bogdandrutu bogdandrutu force-pushed the depoverwritepropertiesconverter branch from f93363e to 99f8d01 Compare October 13, 2022 16:03
@bogdandrutu

This comment was marked as outdated.

@mx-psi

This comment was marked as outdated.

@bogdandrutu bogdandrutu force-pushed the depoverwritepropertiesconverter branch from 99f8d01 to 54af784 Compare October 13, 2022 16:10
@bogdandrutu bogdandrutu force-pushed the depoverwritepropertiesconverter branch 2 times, most recently from 7dbf70c to 161f0cf Compare October 14, 2022 21:50
@bogdandrutu bogdandrutu merged commit ee02bc7 into open-telemetry:main Oct 14, 2022
@bogdandrutu bogdandrutu deleted the depoverwritepropertiesconverter branch October 14, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants