Rename Start() to Run() since it's a blocking call #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilebox
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
|
This a publicly exported function that can be imported elsewhere. Not worth breaking others' code. |
|
Doesn't seem like anyone is using this package yet: https://pkg.go.dev/github.com/open-telemetry/opentelemetry-collector/cmd/otelcol?tab=importedby Even if we do break, it's trivial to fix. It's even more important to fix the confusion for public API IMO. |
|
Sorry, I used the wrong package to check against, it is being used in a few projects indeed: https://pkg.go.dev/github.com/open-telemetry/opentelemetry-collector/service?tab=importedby Sent a new PR that keeps backward compatibility: #615 |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Bumps alpine from 3.14.0 to 3.14.1. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Signed-off-by: Sherif Ayad <[email protected]> Signed-off-by: Sherif Ayad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename Start() to Run() to follow the naming pattern used in Go, e.g. see blocking Cmd.Run vs non-blocking Cmd.Start.