Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change addlicense to use current year #604

Merged

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Mar 9, 2020

Change addlicense target to use the current year

@tigrannajaryan
Copy link
Member

What if we remove the year completely?

@bogdandrutu
Copy link
Member

We can use I think -y=""

@bogdandrutu
Copy link
Member

@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

Merging #604 into master will decrease coverage by 2.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   77.08%   75.07%   -2.02%     
==========================================
  Files         133      137       +4     
  Lines        8472     9144     +672     
==========================================
+ Hits         6531     6865     +334     
- Misses       1641     1966     +325     
- Partials      300      313      +13
Impacted Files Coverage Δ
exporter/exporterhelper/tracehelper.go 93.33% <0%> (ø) ⬆️
translator/trace/oc_to_otlp.go 82.83% <0%> (ø) ⬆️
consumer/consumerdata/consumerdata.go
internal/data/metric.go 20.17% <0%> (ø)
internal/data/trace.go 35.81% <0%> (ø)
internal/data/common.go 100% <0%> (ø)
internal/data/resource.go 0% <0%> (ø)
translator/trace/otlp_to_oc.go 76.22% <0%> (ø)
translator/trace/spandata/protospan_to_spandata.go 60.81% <0%> (+0.69%) ⬆️
exporter/zipkinexporter/zipkin.go 79.31% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feaa497...65171be. Read the comment docs.

@pjanotti
Copy link
Contributor Author

pjanotti commented Mar 9, 2020

Great, -y='' works, there is an extra blank space but that is ok.

@pjanotti
Copy link
Contributor Author

@tigrannajaryan @bogdandrutu - after this one is merged I will remove the year from the existing ones.

@tigrannajaryan tigrannajaryan merged commit b9dfb74 into open-telemetry:master Mar 11, 2020
@pjanotti pjanotti deleted the set-addlicense-to-current-year branch March 8, 2021 20:14
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* update tag.sh to create signed tags.

* rm tag_latest_modulesh.sh
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
… in SA (open-telemetry#604)

Also, don't build a metrics pipeline if there are no metrics receivers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants