Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/batch] Removed casts to Sizer interface in batch processor #5937

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Aug 19, 2022

Description: As a follow up to #5929 removed cast to Sizer interface in batch processor as this is no longer required with the new MarshalerSizer that is returned from NewProtoMarshaler

@cpheps cpheps requested review from a team and dmitryax August 19, 2022 15:28
Signed-off-by: Corbin Phelps <[email protected]>
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. probably don't need a changelog entry since there isn't any user impact from that change.

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #5937 (f59d884) into main (ec04503) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5937   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         200      200           
  Lines       12406    12406           
=======================================
  Hits        11406    11406           
  Misses        789      789           
  Partials      211      211           
Impacted Files Coverage Δ
processor/batchprocessor/batch_processor.go 90.67% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cpheps
Copy link
Contributor Author

cpheps commented Aug 19, 2022

probably don't need a changelog entry since there isn't any user impact from that change.

@TylerHelmuth I can remove it. I think someone has to tag this PR so CI doesn't fail on not having one.

CHANGELOG.md Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 19, 2022
Signed-off-by: Corbin Phelps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants