Upgrade to go1.19 all workflows except testing on go1.18 #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan <[email protected]>
bogdandrutu
force-pushed
the
upgradetogolang1.19
branch
from
c148d4e to
470651a
Compare
Codecov Report
@@ Coverage Diff @@
## main #5877 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 195 195
Lines 11931 11931
=======================================
Hits 10940 10940
Misses 781 781
Partials 210 210
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bogdandrutu
commented
Aug 9, 2022
| @@ -28,7 +28,7 @@ import ( | |||
| // LoadConf loads a confmap.Conf from file, and does NOT validate the configuration. | |||
| func LoadConf(fileName string) (*confmap.Conf, error) { | |||
| // Clean the path before using it. | |||
| content, err := ioutil.ReadFile(filepath.Clean(fileName)) | |||
| content, err := os.ReadFile(filepath.Clean(fileName)) | |||
There was a problem hiding this comment.
I had to do only a small change here.
There was a problem hiding this comment.
i'm surprised this was the only use of ioutil that needed to be changed.
codeboten
approved these changes
Aug 9, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan [email protected]