Remove the InstrumentationLibrary to Scope translation, OTLP 0.19 no longer supports it.

[bogdandrutu]

Kept a generic "Migrate[Logs|Metrics|Traces]" so that if needed in the future we will not forget to update any place.

Fixes #5818

Signed-off-by: Bogdan [email protected]

[bogdandrutu]

Not sure if this should be a "breaking change". Probably to be safe we can say it is.

[codecov]

Codecov Report

Merging #5819 (249d3ce) into main (869dad4) will decrease coverage by 0.03%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main    #5819      +/-   ##
==========================================
- Coverage   91.74%   91.71%   -0.04%     
==========================================
  Files         191      191              
  Lines       11434    11392      -42     
==========================================
- Hits        10490    10448      -42     
  Misses        752      752              
  Partials      192      192              

Impacted Files	Coverage Δ
pdata/plog/plogotlp/logs.go	49.01% <66.66%> (ø)
pdata/ptrace/ptraceotlp/traces.go	49.01% <66.66%> (ø)
pdata/internal/otlp/logs.go	100.00% <100.00%> (ø)
pdata/internal/otlp/metrics.go	100.00% <100.00%> (ø)
pdata/internal/otlp/traces.go	100.00% <100.00%> (ø)
pdata/plog/json.go	85.00% <100.00%> (ø)
pdata/pmetric/json.go	100.00% <100.00%> (ø)
pdata/pmetric/pmetricotlp/metrics.go	53.19% <100.00%> (ø)
pdata/ptrace/json.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[codeboten]

I think the change itself is fine, one question i have is whether there should be a migration guide section somewhere, or at least an indicator of what OTLP protocols are supported by a collector that's easier to find than looking at the Makefile.

This would be to answer questions from users that may upgrade the collector to find that their data is no longer working because they're sending an outdated version of OTLP.

[bogdandrutu]

@codeboten is that not the changelog? Why do we have the changelog then?

[codeboten]

@codeboten is that not the changelog? Why do we have the changelog then?

I guess I was thinking something that is easier to parse ie. the table here: https://github.com/open-telemetry/opentelemetry-operator/#opentelemetry-operator-vs-kubernetes-vs-cert-manager

[codeboten]

With the new changelog entry i think this is ok.