-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add bugfix release criteria #5707
Conversation
docs/release.md
Outdated
- The bug makes the Collector negatively affect its environment (e.g. significantly affects its host machine) | ||
|
||
The OpenTelemetry Collector maintainers will ultimately have the responsibility to assess if a given bug fulfills all the necessary criteria. | ||
Exceptions may be granted in a case-by-case basis if there is widespread consensus that a bugfix release should be done despite the above rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this last line be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the wiggle room, but I think ultimately the "case-by-case" basis is based on the maintainer's judgement. Could modify the line above to be "The OpenTelemetry Collector maintainers will ultimately have the responsibility to assess if a given bug fulfills all the necessary criteria, or should be patched anyways".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworded
Codecov Report
@@ Coverage Diff @@
## main #5707 +/- ##
==========================================
+ Coverage 91.53% 91.56% +0.03%
==========================================
Files 192 192
Lines 11398 11411 +13
==========================================
+ Hits 10433 10449 +16
+ Misses 770 768 -2
+ Partials 195 194 -1
Continue to review full report at Codecov.
|
Co-authored-by: Tyler Helmuth <[email protected]>
Description: Add criteria describing when to make a bugfix release. This is basically a rehash of #5681 (comment) with nicer language and ordered from least to most ambiguous.
Link to tracking Issue: Fixes #5681
cc @codeboten @jpkrohling