Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set log level for undefined stability level to debug #5635

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Set log level for undefined stability level to debug #5635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2539032
Set log level for `undefined` stability level to debug
Jul 6, 2022
64c1276
update changelog
Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
### 🧰 Bug fixes 🧰

- Fix initialization of the OpenTelemetry MetricProvider. (#5571)
- Set log level for `undefined` stability level to debug. (#5635)

## v0.54.0 Beta

Expand Down
2 changes: 1 addition & 1 deletion service/internal/pipelines/pipelines.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ func logStabilityMessage(logger *zap.Logger, sl component.StabilityLevel) {
case component.StabilityLevelAlpha, component.StabilityLevelBeta, component.StabilityLevelStable:
logger.Debug("Stability level", zap.String(components.ZapStabilityKey, sl.String()))
default:
logger.Info("Stability level of component undefined", zap.String(components.ZapStabilityKey, sl.String()))
logger.Debug("Stability level of component undefined", zap.String(components.ZapStabilityKey, sl.String()))
}
}

Expand Down
2 changes: 1 addition & 1 deletion service/internal/pipelines/pipelines_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ func TestLogStabilityLevle(t *testing.T) {
},
{
level: zapcore.InfoLevel,
expectedLogs: 4,
expectedLogs: 3,
},
}

Expand Down