Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config unmarshaler interface, per deprecation comment #5348

Merged
merged 1 commit into from
May 12, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and mx-psi May 11, 2022 22:45
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #5348 (709148a) into main (df91fce) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5348      +/-   ##
==========================================
+ Coverage   90.60%   90.61%   +0.01%     
==========================================
  Files         190      190              
  Lines       11429    11423       -6     
==========================================
- Hits        10355    10351       -4     
+ Misses        853      852       -1     
+ Partials      221      220       -1     
Impacted Files Coverage Δ
service/config_provider.go 90.32% <100.00%> (+14.64%) ⬆️
...e/internal/configunmarshaler/defaultunmarshaler.go 100.00% <100.00%> (ø)
service/servicetest/configprovider.go 76.92% <100.00%> (ø)
pdata/internal/common.go 91.82% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df91fce...709148a. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 40443ec into open-telemetry:main May 12, 2022
@bogdandrutu bogdandrutu deleted the rmunmarshaler branch May 12, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants