Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Remove deprecated primitive slice getters/setters #5347

Merged

Conversation

dmitryax
Copy link
Member

This is the second step in a sequence of backward changes to replace primitive slices with immutable structs #5263

@dmitryax dmitryax requested review from a team and codeboten May 11, 2022 22:44
@dmitryax dmitryax force-pushed the remove-mutable-slice-methods branch 2 times, most recently from 20bf5d0 to cd13d54 Compare May 11, 2022 22:58
This is the second step in a sequence of backward changes to replace primitive slices with immutable structs
@dmitryax dmitryax force-pushed the remove-mutable-slice-methods branch from cd13d54 to 4d5aac8 Compare May 11, 2022 23:01
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #5347 (f55204c) into main (ab79681) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5347      +/-   ##
==========================================
+ Coverage   90.75%   90.97%   +0.22%     
==========================================
  Files         190      190              
  Lines       11422    11392      -30     
==========================================
- Hits        10366    10364       -2     
+ Misses        837      809      -28     
  Partials      219      219              
Impacted Files Coverage Δ
pdata/internal/metrics.go 92.50% <ø> (+8.40%) ⬆️
pdata/internal/common.go 95.38% <100.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab79681...f55204c. Read the comment docs.

@bogdandrutu
Copy link
Member

We probably need to coordinate with @dashpole since most likely Google exporter uses these fields.

@dmitryax
Copy link
Member Author

Yes, a few other distros are using it as well. They should migrate to the methods prefixed with M by the next release according to the schedule defined #5263 . Let me know if that schedule makes sense

@dmitryax
Copy link
Member Author

@bogdandrutu the contrib test is passing now

@bogdandrutu bogdandrutu merged commit b46b7d9 into open-telemetry:main May 18, 2022
@dmitryax dmitryax deleted the remove-mutable-slice-methods branch May 19, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants