Update pdata godoc strings #5226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmitryax
commented
Apr 14, 2022
dmitryax
commented
- Use copy of the godoc comments from pdata/internal instead of mentioning aliases in pdata/p public API docs.
- Update godoc strings in both pdata/p and pdata/internal to keep them consistent.
dmitryax
force-pushed
the
update-pdata-dogoc
branch
from
f00b7a8 to
ddf7aaf
Compare
bogdandrutu
reviewed
Apr 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #5226 +/- ##
=======================================
Coverage 90.51% 90.51%
=======================================
Files 186 186
Lines 11033 11033
=======================================
Hits 9987 9987
Misses 824 824
Partials 222 222
Continue to review full report at Codecov.
|
- Use copy of the godoc comments from pdata/internal instead of mentioning aliases in pdata/p<signal> public API docs. - Update godoc strings in both pdata/p<signal> and pdata/internal to keep them consistent.
dmitryax
force-pushed
the
update-pdata-dogoc
branch
from
ddf7aaf to
5b1009a
Compare
bogdandrutu
approved these changes
Apr 14, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
- Use copy of the godoc comments from pdata/internal instead of mentioning aliases in pdata/p<signal> public API docs. - Update godoc strings in both pdata/p<signal> and pdata/internal to keep them consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.