Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[model/semconv] Add generated_ prefix to generated files #5148

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 4, 2022

For consistency with other generated filenames across the collector repos. This also helps to distinguish files that has to be manually created for each semconv release.

@dmitryax dmitryax requested review from a team and Aneurysm9 April 4, 2022 23:31
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #5148 (4f5f192) into main (caa4f27) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5148   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files         182      182           
  Lines       11031    11031           
=======================================
  Hits         9966     9966           
  Misses        840      840           
  Partials      225      225           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa4f27...4f5f192. Read the comment docs.

For consistency with other generated names in across the collector repos. This also helps to distinguish files that has to be manually created for each semconv version.
@dmitryax dmitryax force-pushed the semconv_generated branch from 1d006ab to 4f5f192 Compare April 4, 2022 23:37
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 4, 2022
@bogdandrutu bogdandrutu merged commit ff6a8f6 into open-telemetry:main Apr 5, 2022
@dmitryax dmitryax deleted the semconv_generated branch April 5, 2022 21:28
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
…metry#5148)

For consistency with other generated names in across the collector repos. This also helps to distinguish files that has to be manually created for each semconv version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants