Change structs in otlpgrpc to follow standard go encoding interfaces #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
encodingintf
branch
from
6e7d9b6 to
2a74e47
Compare
Codecov Report
@@ Coverage Diff @@
## main #5062 +/- ##
=======================================
Coverage 91.01% 91.02%
=======================================
Files 180 180
Lines 10814 10826 +12
=======================================
+ Hits 9842 9854 +12
- Misses 752 753 +1
+ Partials 220 219 -1
Continue to review full report at Codecov.
|
dmitryax
approved these changes
Mar 22, 2022
mx-psi
reviewed
Mar 23, 2022
* Change `UnmarshalJSON[Traces|Metrics|Logs][Reques|Response]` to be a func `UnmarshalJSON` on the struct. * Rename `[Traces|Metrics|Logs][Reques|Response].Marshal` to `MarshalProto` consistent with JSON/Text standard interfaces. * Change `UnmarshalJSON[Traces|Metrics|Logs][Reques|Response]` to be a func `UnmarshalProto` on the struct. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
encodingintf
branch
from
a3473a8 to
7afe523
Compare
mx-psi
approved these changes
Mar 24, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…pen-telemetry#5062) * Change `UnmarshalJSON[Traces|Metrics|Logs][Reques|Response]` to be a func `UnmarshalJSON` on the struct. * Rename `[Traces|Metrics|Logs][Reques|Response].Marshal` to `MarshalProto` consistent with JSON/Text standard interfaces. * Change `UnmarshalJSON[Traces|Metrics|Logs][Reques|Response]` to be a func `UnmarshalProto` on the struct. Signed-off-by: Bogdan Drutu <[email protected]>
JimChenWYU
pushed a commit
to easyops-cn/opentelemetry-collector
that referenced
this pull request
Jun 9, 2023
…ated by prometheus, rather than making our own (open-telemetry#3989) * Revert "receiver/prometheus: glue and complete staleness marking for disappearing metrics (open-telemetry#3423)" This reverts commit 8b79380. * Revert "receiver/prometheus: add store to track stale metrics (open-telemetry#3414)" This reverts commit cdc1634. * stop dropping staleness markers from prometheus, and fix tests * add staleness end to end test from open-telemetry#3423 * fix import grouping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnmarshalJSON[Traces|Metrics|Logs][Reques|Response]to be a funcUnmarshalJSONon the struct.[Traces|Metrics|Logs][Reques|Response].MarshaltoMarshalProtoconsistent with JSON/Text standard interfaces.UnmarshalJSON[Traces|Metrics|Logs][Reques|Response]to be a funcUnmarshalProtoon the struct.Signed-off-by: Bogdan Drutu [email protected]