Change parameter 'location' to a more relevant name #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5058 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 180 180
Lines 10810 10814 +4
=======================================
+ Hits 9842 9846 +4
Misses 749 749
Partials 219 219
Continue to review full report at Codecov.
|
|
/cc @mx-psi |
|
I am unsure if this PR needs a changelog. Let me know if its needs one and I can add it. |
|
You need a rebase, don't feel strong about changelog, we can skip. |
hickeyma
force-pushed
the
change-location-name
branch
from
14b2df1 to
c12bf26
Compare
The parameter `location` used in the `Retrieve` function of the `Provider` interface does not clearly define what it is. This PR changes it to `uri` as it more clearly defines its value, which is a data URI scheme. Closes open-telemetry#5002. Signed-off-by: Martin Hickey <[email protected]>
hickeyma
force-pushed
the
change-location-name
branch
from
c12bf26 to
2d175a2
Compare
|
Thanks for heads up @bogdandrutu, rebased. |
bogdandrutu
approved these changes
Mar 23, 2022
mx-psi
approved these changes
Mar 23, 2022
|
Thanks @bogdandrutu @mx-psi for reviews and merge. |
6 tasks
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
) The parameter `location` used in the `Retrieve` function of the `Provider` interface does not clearly define what it is. This PR changes it to `uri` as it more clearly defines its value, which is a data URI scheme. Closes open-telemetry#5002. Signed-off-by: Martin Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter
locationused in theRetrievefunction of theProviderinterface does not clearly define what it is.This PR changes it to
urias it more clearly defines its value, which is a data URI scheme.Closes #5002.
Signed-off-by: Martin Hickey [email protected]