-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag to allow enabling otel for internal metrics #4912
Add feature flag to allow enabling otel for internal metrics #4912
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry
update description with suggested change Co-authored-by: Anthony Mirabella <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@splunkericl please address build failure issues
@codeboten I have made a couple changes to fix lint, import order and unit test. can you run the approval workflow again? |
Codecov Report
@@ Coverage Diff @@
## main #4912 +/- ##
==========================================
+ Coverage 90.82% 91.03% +0.20%
==========================================
Files 181 180 -1
Lines 10632 10628 -4
==========================================
+ Hits 9657 9675 +18
+ Misses 759 736 -23
- Partials 216 217 +1
Continue to review full report at Codecov.
|
@dmitryax can you please take a look on the change? |
Description:
Previously, the variable to gate using open telemetry metrics was a constant and always set to false. This prevents any otel collector users to enable the feature.
This change will now use feature gate flag instead. The user can register the feature flag in their code base and enable the feature.
Link to tracking Issue:
#4694
Testing:
Added unit test to run otel collector with the flag enabled. Verify and assert the metrics endpoint.
Documentation:
feature gate ID variable documentation was added.