Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow direct implementation of retrieved #4577

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and owais December 17, 2021 23:22
@bogdandrutu bogdandrutu force-pushed the disallowretrived branch 3 times, most recently from 4004f9a to 684c3e2 Compare December 17, 2021 23:51
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #4577 (ca81d81) into main (1941cc1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4577      +/-   ##
==========================================
+ Coverage   90.70%   90.73%   +0.02%     
==========================================
  Files         180      180              
  Lines       10576    10605      +29     
==========================================
+ Hits         9593     9622      +29     
  Misses        765      765              
  Partials      218      218              
Impacted Files Coverage Δ
config/configmapprovider/env.go 100.00% <100.00%> (ø)
config/configmapprovider/expand.go 78.18% <100.00%> (+0.82%) ⬆️
config/configmapprovider/file.go 100.00% <100.00%> (ø)
config/configmapprovider/merge.go 91.17% <100.00%> (+1.17%) ⬆️
config/configmapprovider/properties.go 90.62% <100.00%> (+0.96%) ⬆️
config/configmapprovider/retrieved.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1941cc1...ca81d81. Read the comment docs.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit 81ab024 into open-telemetry:main Dec 18, 2021
@bogdandrutu bogdandrutu deleted the disallowretrived branch December 20, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants