Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce optional memory ballast #45

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Introduce optional memory ballast #45

merged 1 commit into from
Jun 25, 2019

Commits on Jun 25, 2019

  1. Introduce optional memory ballast

    This change add an optional memory ballast to help with ease GC pressure
    in high thoughput scenarios
    
    - Added new CLI flag called `--mem-ballast-size-mib` which represents
    the size of memory ballast to use in MiB. Omitting the value or setting
    it to zero does not set the ballast.
    
    - Updated process telemetry code to account for the ballast and report
    memory usage statistics after subtracting the ballast size. I'm not sure
    if this makes sense in every scenario. If not, we can add another flag
    to disable the behaviour. Another option is to add one more metric that
    just exports the memory ballast size as a static number and then let
    metric consumers to adjust the numbers.
    
    https://blog.twitch.tv/go-memory-ballast-how-i-learnt-to-stop-worrying-and-love-the-heap-26c2462549a2
    
    golang/go#23044
    owais committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    26b7fe5 View commit details
    Browse the repository at this point in the history