Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message for New funcs in pdata #4402

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Nov 11, 2021

Updates #4254

Try to remove the confusion that the pdata.Metrics cannot be constructed.

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and owais November 11, 2021 21:42
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #4402 (c8a77d0) into main (a0d9d43) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4402      +/-   ##
==========================================
+ Coverage   90.31%   90.40%   +0.09%     
==========================================
  Files         177      177              
  Lines       10338    10333       -5     
==========================================
+ Hits         9337     9342       +5     
+ Misses        779      774       -5     
+ Partials      222      217       -5     
Impacted Files Coverage Δ
model/pdata/generated_common.go 100.00% <ø> (ø)
model/pdata/generated_log.go 96.65% <ø> (ø)
model/pdata/generated_metrics.go 96.98% <ø> (ø)
model/pdata/generated_resource.go 100.00% <ø> (ø)
model/pdata/generated_trace.go 96.88% <ø> (ø)
exporter/loggingexporter/config.go 100.00% <0.00%> (ø)
exporter/loggingexporter/logging_exporter.go 93.47% <0.00%> (+3.05%) ⬆️
exporter/loggingexporter/factory.go 77.35% <0.00%> (+4.14%) ⬆️
service/config_watcher.go 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d9d43...c8a77d0. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 7e7323b into open-telemetry:main Nov 11, 2021
@bogdandrutu bogdandrutu deleted the improvemessage branch November 11, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants