Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log useful error when receiver creation fails. #430

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Nov 22, 2019

fixes #429

Also modified .gitignore to ignore *.iml files.

@codecov-io
Copy link

Codecov Report

Merging #430 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #430     +/-   ##
=========================================
+ Coverage   75.11%   75.22%   +0.1%     
=========================================
  Files         118      118             
  Lines        7234     7232      -2     
=========================================
+ Hits         5434     5440      +6     
+ Misses       1536     1529      -7     
+ Partials      264      263      -1
Impacted Files Coverage Δ
service/builder/receivers_builder.go 82.5% <100%> (+6.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62525d...07828b1. Read the comment docs.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rghetia

@pjanotti pjanotti merged commit 28e7622 into open-telemetry:master Dec 4, 2019
@rghetia rghetia deleted the receiver_error branch December 4, 2019 23:52
@rghetia rghetia restored the receiver_error branch December 5, 2019 00:05
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
Spans should not have the Tracer name as a prefix for their names. This
removes the `spanNameWithPrefix` function and instead passes through the
span name unmodified wherever this had been called.

Tests that checked Span names are updated to have the non-prefix
expected names.
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…pen-telemetry#430)

Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.16.0 to 1.17.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.16.0...v1.17.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

receiver creation error is very generic without providing any details
4 participants