Disable current workflows for builder #4287
Conversation
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
|
In addition to this PR, I will need the currently required checks to not be required anymore, such as:
Once the move is complete, we can enable some/most of them back. |
Codecov Report
@@ Coverage Diff @@
## main #4287 +/- ##
==========================================
+ Coverage 88.39% 88.45% +0.05%
==========================================
Files 173 173
Lines 10446 10443 -3
==========================================
+ Hits 9234 9237 +3
+ Misses 975 969 -6
Partials 237 237
Continue to review full report at Codecov.
|
| @@ -7,6 +7,8 @@ | |||
| name: "Inform Incompatible PRs" | |||
| on: | |||
| pull_request: | |||
| paths-ignore: | |||
| - 'builder/**' | |||
There was a problem hiding this comment.
As mentioned in the other PR, I would prefer cmd/builder since it is a command :)
There was a problem hiding this comment.
This is the first step of a multi-step move. The other PR is mostly the whole repo of builder with its history, all places in one directory. If you prefer the whole application to be within cmd/builder, that's doable, but if you mean just the main.go for the application, then I will tackle that in subsequent PRs.
| paths-ignore: | ||
| - 'builder/**' |
There was a problem hiding this comment.
This is the tidier, shouldn't be critical for this first step. Or is it?
| paths-ignore: | ||
| - 'builder/**' | ||
| pull_request: | ||
| paths-ignore: | ||
| - 'builder/**' |
There was a problem hiding this comment.
codeql should run all the time even for builder.
There was a problem hiding this comment.
Agree, and I think this might already work out of the box. If it doesn't after merging this, I'll open another PR disabling CodeQL temporarily.
| paths-ignore: | ||
| - 'builder/**' | ||
| pull_request: | ||
| paths-ignore: | ||
| - 'builder/**' |
There was a problem hiding this comment.
links check is ok to run for the builder as well.
There was a problem hiding this comment.
They are currently failing with the link checks for the release instructions, as I reference a non-existing tag as example. I have a first ready for this, to be sent on a third PR.
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
This PR is in preparation for moving the builder to the core repository (#4275 and #4286)
Signed-off-by: Juraci Paixão Kröhling [email protected]