Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impi to ensure import organization #426

Merged

Conversation

ferhatelmas
Copy link
Contributor

Similar to open-telemetry/opentelemetry-collector-contrib#42

Add impi to ensure import organization (std, 3rd party and local).

@codecov-io
Copy link

Codecov Report

Merging #426 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   75.08%   75.11%   +0.02%     
==========================================
  Files         118      118              
  Lines        7234     7234              
==========================================
+ Hits         5432     5434       +2     
+ Misses       1538     1536       -2     
  Partials      264      264
Impacted Files Coverage Δ
...iver/prometheusreceiver/internal/metricsbuilder.go 96.71% <ø> (ø) ⬆️
receiver/opencensusreceiver/factory.go 89.18% <ø> (ø) ⬆️
receiver/prometheusreceiver/metrics_receiver.go 74.46% <ø> (ø) ⬆️
...eceiver/prometheusreceiver/internal/transaction.go 75.75% <ø> (ø) ⬆️
observability/observability.go 50% <ø> (ø) ⬆️
...eceiver/opencensusreceiver/ocmetrics/opencensus.go 78.57% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567e104...a33c103. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@tigrannajaryan tigrannajaryan merged commit a62525d into open-telemetry:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants