Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to defaultcomponents in core and deprecate include_core flag #4087

Merged
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
a5f22cb
remove defaultComponents from core and make it internal for tests
JamesJHPark Sep 17, 2021
8bd970a
remove package-lock.json file
JamesJHPark Sep 17, 2021
50f6733
remove checkdoc from GitHub actions workflow
JamesJHPark Sep 17, 2021
72af5bd
fix merge conflict
JamesJHPark Sep 22, 2021
3dd7e8f
Merge remote-tracking branch 'origin/remove-default-components-from-c…
JamesJHPark Sep 22, 2021
b610db0
add CHANGELOG entry
JamesJHPark Sep 23, 2021
02a2cd7
add checkdoc to github workflow
JamesJHPark Sep 26, 2021
0468ebd
testing lint check
JamesJHPark Sep 26, 2021
7916f74
resolve merge conflicts
JamesJHPark Sep 28, 2021
a2a9f4c
update additional files
JamesJHPark Sep 28, 2021
eeecba5
resolve merge conflicts
JamesJHPark Sep 29, 2021
83f30f7
Merge branch 'main' into remove-default-components-from-core
JamesJHPark Sep 29, 2021
50cb63e
remove-default-components-from-core
JamesJHPark Sep 29, 2021
9c07faa
add import statement
JamesJHPark Sep 29, 2021
e7d6e0e
fix Makefile
JamesJHPark Sep 29, 2021
fb8f888
add changelog entry
JamesJHPark Sep 29, 2021
c27fdd1
resolve merge conflit add to changelog
JamesJHPark Oct 13, 2021
33ed6ac
lint check
JamesJHPark Oct 13, 2021
2bffc9b
Merge branch 'main' into remove-default-components-from-core
JamesJHPark Oct 14, 2021
7a1ed63
fix lint test
JamesJHPark Oct 14, 2021
a589022
resolve merge conflict
JamesJHPark Nov 3, 2021
29b6670
run integration tests
JamesJHPark Nov 3, 2021
ba8bc42
partially removed dependency on real components for tests, removed re…
JamesJHPark Nov 16, 2021
f3803e6
fix lint
JamesJHPark Nov 16, 2021
c40cda1
Modify changelog entry
JamesJHPark Nov 18, 2021
cb298f9
remove include_core flag in builder
JamesJHPark Nov 30, 2021
9d27051
deprecate include_core flag
JamesJHPark Nov 30, 2021
61132c3
modify include_core flag comment
JamesJHPark Dec 1, 2021
02d0782
resolve merge conflict
JamesJHPark Dec 2, 2021
4433904
deprecate include_core flag revised
JamesJHPark Dec 2, 2021
ea97c11
deprecate include_core flag revised with log messages
JamesJHPark Dec 3, 2021
f09eeef
commit initial test for codecov
JamesJHPark Dec 4, 2021
c58836f
fixed test
JamesJHPark Dec 4, 2021
5f9b4e0
add changelog entry
JamesJHPark Dec 8, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
- Rename `configparser.Parser` as `config.Map` (#4075)
- Rename `component.DefaultBuildInfo()` to `component.NewDefaultBuildInfo()` (#4129)
- Rename consumererror.Permanent to consumererror.NewPermanent (#4118)
- Move `extension/storage` to `extension/experimental/storage` (#4082)
- Rename `config.NewID` to `config.NewComponentID` and `config.NewIDFromString` to `config.NewComponentIDFromString` (#4137)
- Remove `defaultcomponents` from core (#4087).

## 💡 Enhancements 💡

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ BUILD_INFO=-ldflags "-X $(BUILD_INFO_IMPORT_PATH).Version=$(VERSION)"

RUN_CONFIG?=examples/local/otel-config.yaml
CONTRIB_PATH=$(CURDIR)/../opentelemetry-collector-contrib
COMP_REL_PATH=service/defaultcomponents/defaults.go
COMP_REL_PATH=internal/collector/defaultcomponents/defaults.go
MOD_NAME=go.opentelemetry.io/collector

ADDLICENSE=addlicense
Expand Down
2 changes: 1 addition & 1 deletion cmd/otelcol/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ import (
"log"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/internal/collector/defaultcomponents"
"go.opentelemetry.io/collector/internal/version"
"go.opentelemetry.io/collector/service"
"go.opentelemetry.io/collector/service/defaultcomponents"
)

func main() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ import (
"go.opentelemetry.io/collector/receiver/otlpreceiver"
)

// Components returns the default set of components used by the
// OpenTelemetry collector.
// Components returns the default set of components used by the OpenTelemetry collector.
func Components() (
component.Factories,
error,
Expand Down
2 changes: 1 addition & 1 deletion service/collector_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ import (
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/config"
"go.opentelemetry.io/collector/config/configunmarshaler"
"go.opentelemetry.io/collector/internal/collector/defaultcomponents"
"go.opentelemetry.io/collector/internal/testutil"
"go.opentelemetry.io/collector/service/defaultcomponents"
"go.opentelemetry.io/collector/service/internal/builder"
"go.opentelemetry.io/collector/service/parserprovider"
)
Expand Down
2 changes: 1 addition & 1 deletion service/collector_windows_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"golang.org/x/sys/windows/svc"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/service/defaultcomponents"
"go.opentelemetry.io/collector/internal/collector/defaultcomponents"
)

func TestWindowsService_Execute(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion service/configcheck_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/config"
"go.opentelemetry.io/collector/service/defaultcomponents"
"go.opentelemetry.io/collector/internal/collector/defaultcomponents"
)

func TestValidateConfigFromFactories_Success(t *testing.T) {
Expand Down
153 changes: 0 additions & 153 deletions service/defaultcomponents/default_exporters_test.go

This file was deleted.

120 changes: 0 additions & 120 deletions service/defaultcomponents/default_extensions_test.go

This file was deleted.

Loading