Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove AttributeMessageType #4020

Merged

Conversation

hyunuk
Copy link
Contributor

@hyunuk hyunuk commented Sep 11, 2021

Description:
Removes AttributeMessageType from /model/semconv/v1.5.0/nonstandard.go

Link to tracking Issue:
This PR and PR in contrib/5186 addresses #3998 in the collector repository.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry in the CHANGELOG

@bogdandrutu
Copy link
Member

Please rebase

@hyunuk hyunuk requested a review from bogdandrutu September 13, 2021 18:23
@bogdandrutu
Copy link
Member

Please fix lint errors

@bogdandrutu bogdandrutu merged commit db1b3b1 into open-telemetry:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants