Add configuration to setup collector logs via config file. #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
addloggerconfig
branch
from
314d3f8 to
fd8dead
Compare
mx-psi
reviewed
Sep 10, 2021
bogdandrutu
force-pushed
the
addloggerconfig
branch
from
fd8dead to
fa19e41
Compare
mx-psi
approved these changes
Sep 10, 2021
|
Please review @Aneurysm9 |
bogdandrutu
force-pushed
the
addloggerconfig
branch
2 times, most recently
from
3e5596c to
348503b
Compare
Next PRs will use this configuration and it will deprecate/remove the flags. Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
addloggerconfig
branch
from
348503b to
4bf1fde
Compare
jpkrohling
reviewed
Sep 15, 2021
jpkrohling
approved these changes
Sep 15, 2021
|
@tigrannajaryan @Aneurysm9 please review asap. This is a P0 issue and we need to get this merged. Thx!!! |
Aneurysm9
approved these changes
Sep 15, 2021
I already reviewed. Not sure what's the urgency. This appears to be a backwards compatible change. |
anuraaga
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: #3957
Next PRs will use this configuration and it will deprecate/remove the flags.
Signed-off-by: Bogdan Drutu [email protected]