Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup service, combine small functions to better read the overall flow #4006

Merged
merged 3 commits into from
Sep 11, 2021
Merged

Cleanup service, combine small functions to better read the overall flow #4006

merged 3 commits into from
Sep 11, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 10, 2021 •
edited
Loading

Updates: #3957

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and codeboten September 10, 2021 11:01
mx-psi
mx-psi approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Two comments on error wording (they were already present but we may as well deal with them now)

service/service.go Outdated Show resolved Hide resolved
service/service.go Outdated Show resolved Hide resolved
Bogdan Drutu and others added 2 commits September 10, 2021 16:02
@mx-psi
Update service/service.go
a766f0c 
Co-authored-by: Pablo Baeyens <[email protected]>
@mx-psi
Update service/service.go
bd81ecc 
Co-authored-by: Pablo Baeyens <[email protected]>
@bogdandrutu bogdandrutu merged commit 0d27154 into open-telemetry:main Sep 11, 2021
@bogdandrutu bogdandrutu deleted the cleanupservice branch September 11, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@dashpole dashpole dashpole approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdandrutu @codeboten @dashpole @mx-psi